-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environment info to make troubleshoot
.
#171
base: master
Are you sure you want to change the base?
Conversation
Could you also attach the output of |
@@ -160,12 +161,13 @@ update-theos:: | |||
|
|||
troubleshoot:: | |||
@$(PRINT_FORMAT) "Be sure to check the troubleshooting page at https://github.com/theos/theos/wiki/Troubleshooting first." | |||
@$(PRINT_FORMAT) "For support with build errors, ask on IRC: http://iphonedevwiki.net/index.php/IRC. If you think you've found a bug in Theos, check the issue tracker at https://github.com/theos/theos/issues." | |||
@$(PRINT_FORMAT) "For support with build errors, ask on IRC: http://iphonedevwiki.net/index.php/IRC. If you think you’ve found a bug in Theos, check the issue tracker at https://github.com/theos/theos/issues." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change needed?
$(MAKE) -f $(_THEOS_PROJECT_MAKEFILE_NAME) --no-print-directory --no-keep-going clean all messages=yes FORCE_COLOR=yes 2>&1 | ghost -x 2w - ansi | ||
@$(PRINT_FORMAT_STAGE) 6 "Gathering troubleshooting information and uploading to Ghostbin" | ||
$(ECHO_NOTHING)MAKE="$(MAKE)" MAKEFILE_NAME="$(_THEOS_PROJECT_MAKEFILE_NAME)" TARGET="$(TARGET)" SYSROOT="$(SYSROOT)" \ | ||
$(THEOS_BIN_PATH)/get-troubleshoot-info | ghost -x 2w - markdown$(ECHO_END) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add -S https://ghostbin.co
to ghost
's arguments.
What does this implement/fix? Explain your changes.
This implements some extra info in the
make troubleshoot
output, as @uroboro requested in #136. Here is a sample: https://ghostbin.com/paste/hudmrAny other comments?
Please vote on this using the reaction button, and comment if you have anything to say. Anything else useful I could add?
Not completely working yet. As you can see, we can’t really get at
$TARGET
and$SYSROOT
as the logic for them doesn’t execute yet. Some version outputs are also pretty wordy, even after some basic parsing.Where has this been tested?
Operating System: macOS 10.12
Target Platform: iOS
Toolchain Version: Xcode 8.0
SDK Version: iOS 10.0